No definition sample set
Started by marccobe




2 posts in this topic
marccobe

9 posts 3 threads Joined: Mar 2021
26-08-21, 10:16 -
#1
Hi everyone,

In the basic case of not using a definition.txt at all (just numbers + .wav), the samples are played with different velocity levels, even if I have set up the configuration file as per original SamplerBox use (127 velocity_levels and sample velocity_mode). Is this a normal behaviour? 
Is there a way a simple set with no definition, uses only one velocity sample? 
In my case this set up will be great for basic drumpads on my keyboard. 

Thanks a lot!
Marc 
hansehv

168 posts 17 threads Joined: Dec 2020
Bug  27-08-21, 15:38 -
#2
(26-08-21, 10:16)marccobe Wrote: In the basic case of not using a definition.txt at all (just numbers + .wav), the samples are played with different velocity levels, even if I have set up the configuration file as per original SamplerBox use (127 velocity_levels and sample velocity_mode). Is this a normal behaviour? 
Hi Marc,
No, not normal: you found a bug  Blush

In samplerbox.py, at around lines 1450-1470, find line with:
Code:
gv.samples[midinote,1,1] = [Sound(file, 1, midinote, 1, PREVELOLEVS, VELACCURATE, gv.sample_mode, PRERELEASE, PREDAMP, PREDAMPNOISE, PRERETRIGGER, gv.globalgain, PREMUTEGROUP, BOXRELSAMPLE, PREXFADEOUT, PREXFADEIN, PREXFADEVOL, PREFRACTIONS)]
and replace VELACCURATE with PREVELMODE

Changing the velocity levels is not necessary, unless you have velocity level samples which isn't common in most percussion sets. Full details in Velocity level differentation in samples.

Thanks for reporting this,
Hans
marccobe

9 posts 3 threads Joined: Mar 2021
Wink  27-08-21, 20:01 -
#3
Hi Hans, 

Thanks to you, always glad to help (even if it is with little things). 
I have changed samplerbox.py and works as expected, thanks for answering so fast.
The more I look into all the new changes and updates from the new version the more I love them! Thanks for all the time and effort behind it, and for sharing it with us. 

PD: I am using 127 velocity levels as I still have some samples configured as per the older samplerbox versions, but I am on the way of changing all the definition files to the new parameters. It will help me specially on the samples' loading time Smile 

Best, 
Marc