Hi Squar0L,
Both are interesting.
I never got to adding rotary encoder support for the simple reason I don't use buttons anymore and therefor don't have the hardware. But it sure is an enhancement for those using buttons (and perhaps for me in future), because the menu system is cumbersome via buttons alone.
However I believe they can be attached to the available ports without needing an extra MCP23017.
And as I see it, the menu system can be operated with two buttons and one rotary ending in the need of 4 data pins - which are available. But you may have made another setup.
Besides, it may be a good idea to use an MCP, because then the occasional noise of the direct GPIO attached hardware might be suppressed (interesting thing to test..)
Framebuffer display is even more interesting.
- Did you need to install extra software/drivers on the image ?
- What pip install packages did you have to add ?
- Are you using it as a display only ?
So I welcome PR's, some notes on this:
Please make separate optional modules.
I am about to release a new version which some serious changes:
- The image has a changed setup (OS, folder structure etc), giving (amongst others) PI4 support.
- The language is upgraded to python3, which has some incompatibilities with python2. During the 2=>3 migration I also changed & optimized the samplerbox code itself at various places.
Given the short time for the new release I am not accepting PR's on current version to be ported to the new version anymore. Sorry for this, but it's too complicated to merge incompatible branches - I hope you understand.
So options are to wait till the release (around christmas) or send me a PM to discuss a workaround.
The python3 branch on GitHub is subject to updates, so for the moment use this for information/introduction only. At release date it will be transferred to master and the python2 version will become a separate frozen branch.
Thanks for your input!
Hans